Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1184493003: Add support for walking stack frames from hydrogen stubs (Closed)

Created:
5 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 6 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add support for walking stack frames from hydrogen stubs R=yangguo@chromium.org BUG=none LOG=n Committed: https://crrev.com/b935e44c79f3b8e0300bfc0e9c4fba04e94b73e5 Cr-Commit-Position: refs/heads/master@{#28984}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M src/frames.cc View 1 1 chunk +21 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
ptal
5 years, 6 months ago (2015-06-12 07:33:06 UTC) #1
Yang
On 2015/06/12 07:33:06, jochen wrote: > ptal lgtm if you add comment regarding non-hydrogen handlers.
5 years, 6 months ago (2015-06-12 07:46:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184493003/20001
5 years, 6 months ago (2015-06-12 07:48:29 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-12 08:27:54 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 08:28:10 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b935e44c79f3b8e0300bfc0e9c4fba04e94b73e5
Cr-Commit-Position: refs/heads/master@{#28984}

Powered by Google App Engine
This is Rietveld 408576698