Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1184493002: Document and measure the TextEvent interface and the textinput event (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Document and measure the TextEvent interface and the textinput event BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197042

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M Source/core/events/EventTarget.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/events/TextEvent.idl View 1 chunk +13 lines, -8 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
philipj_slow
PTAL
5 years, 6 months ago (2015-06-11 19:39:41 UTC) #2
Jens Widell
LGTM
5 years, 6 months ago (2015-06-12 05:50:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184493002/20001
5 years, 6 months ago (2015-06-12 14:17:09 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 15:32:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197042

Powered by Google App Engine
This is Rietveld 408576698