Issue 1184483002: Teach stack to size to the max of its non-positioned children

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1184483002: Teach stack to size to the max of its non-positioned children (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Teach stack to size to the max of its non-positioned children Previously, it would always try to be as big as possible. This CL fixes a problem with the search bar whereby the text wasn't centered. Now the Stack for the text sizes its height properly and then becomes centered. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/befd802e7a2140e1672de2543c423e55297b2621

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -43 lines)			Patch
	M	sky/sdk/lib/framework/rendering/box.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	sky/sdk/lib/framework/rendering/stack.dart	View		3 chunks	+125 lines, -43 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 6 months ago (2015-06-11 19:32:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
befd802e7a2140e1672de2543c423e55297b2621 (presubmit successful).