Implement chinese counter styles

Implement chinese counter styles

After r197154 it turned out the counter-style tests [1] do not actually
use cjk-ideographic but rather the explicit chinese styles. This patch
implements the 4 chinese counter styles and adds the tests from the test suite.

This means the previously added tests from css3-counter-styles-081.html
until css3-counter-styles-085.html do not longer need the explicitly
added cjk-ideographic to work.

This patch also changes the suffix for chinese counter styles to match
the spec [2].

[1] https://github.com/w3c/csswg-test/tree/master/css-counter-styles-3/i18n
[2] http://dev.w3.org/csswg/css-counter-styles/#limited-chinese

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197575

[rwlbuis, 2015-06-17 23:45:38]

rob.buis@samsung.com changed reviewers:
+ kojii@chromium.org, tkent@chromium.org

[rwlbuis, 2015-06-17 23:45:38]

PTAL

[kojii, 2015-06-21 19:21:23]

Non-owner LGTM.

I was thinking to import these tests from CSS WG rather than copying, but it
turned out that these are manual tests that we cannot import. There's no way to
test counter-styles automatically without using internals.

Double-checked all 4 Chinese styles produce the same results as Firefox nightly.

[tkent, 2015-06-22 01:14:14]

lgtm

https://codereview.chromium.org/1184433004/diff/40001/Source/core/layout/Layo...
File Source/core/layout/LayoutListMarker.cpp (right):

https://codereview.chromium.org/1184433004/diff/40001/Source/core/layout/Layo...
Source/core/layout/LayoutListMarker.cpp:338: SecondGroupMarker = 1,
ThirdGroupMarker = 3, FourthGroupMarker = 5,
Please add a comment about 2, 4, and 6.

https://codereview.chromium.org/1184433004/diff/40001/Source/core/layout/Layo...
Source/core/layout/LayoutListMarker.cpp:352: const int groupLength = 9; // 4
digits, 3 digit markers, and a group marker
Please update the comment

[rwlbuis, 2015-06-22 12:50:46]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2015-06-22 12:50:46]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
kojii@chromium.org
Link to the patchset: https://codereview.chromium.org/1184433004/#ps60001
(title: "Patch for landing")

[commit-bot: I haz the power, 2015-06-22 12:50:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1184433004/60001

[commit-bot: I haz the power, 2015-06-22 13:53:55]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197575

[rwlbuis, 2015-06-22 15:31:43]

On 2015/06/21 19:21:23, kojii wrote:
> Non-owner LGTM.

Thanks!

> I was thinking to import these tests from CSS WG rather than copying, but it
> turned out that these are manual tests that we cannot import. There's no way
to
> test counter-styles automatically without using internals.

Yes, that is very unfortunate :( Editing them to match our internals is
cumbersome and error prone. The only way to solve this may be if there was some
standardized JS framework for testing this.