Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 118443009: Fix link templates for mailer. (Closed)

Created:
7 years ago by ghost stip (do not use)
Modified:
7 years ago
Reviewers:
agable
CC:
chromium-reviews, cmp+cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M gatekeeper_mailer.py View 1 chunk +1 line, -1 line 0 comments Download
M templates/base_mail.html View 1 chunk +1 line, -1 line 0 comments Download
M templates/mail_text.txt View 2 chunks +1 line, -2 lines 0 comments Download
M templates/waterfall_mail.html View 1 chunk +1 line, -1 line 0 comments Download
M tests/test_mailer/expected.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/test_mailer/input.json View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 3 (0 generated)
ghost stip (do not use)
ptal https://codereview.chromium.org/118443009/diff/1/tests/test_mailer/input.json File tests/test_mailer/input.json (right): https://codereview.chromium.org/118443009/diff/1/tests/test_mailer/input.json#newcode1 tests/test_mailer/input.json:1: {"url": "https://chromium-gatekeeper-mailer.appspot.com/email", "message": "{\"blamelist\": [\"akalin@chromium.org\", \"lazyboy@chromium.org\", \"noamsml@chromium.org\", \"rmsousa@chromium.org\"], ...
7 years ago (2013-12-20 22:39:00 UTC) #1
ghost stip (do not use)
Committed patchset #1 manually as r242195.
7 years ago (2013-12-20 22:39:40 UTC) #2
agable
7 years ago (2013-12-21 00:32:46 UTC) #3
Message was sent while issue was closed. 
lgtm

https://codereview.chromium.org/118443009/diff/1/tests/test_mailer/input.json
File tests/test_mailer/input.json (right):

https://codereview.chromium.org/118443009/diff/1/tests/test_mailer/input.json...
tests/test_mailer/input.json:1: {"url":
"https://chromium-gatekeeper-mailer.appspot.com/email", "message":
"{\"blamelist\": [\"akalin@chromium.org\", \"lazyboy@chromium.org\",
\"noamsml@chromium.org\", \"rmsousa@chromium.org\"], \"build_url\":
\"http://build.chromium.org/p/chromium/builders/Linux x64/builds/54475\",
\"builderName\": \"Linux x64\", \"changes\": [{\"at\": \"Fri 16 Aug 2013
14:20:12\", \"branch\": \"src\", \"category\": null, \"comments\": \"Added
singleton factory for ServiceDiscoveryHostClient\\n\\nAdded singleton factory
for ServiceDiscoveryHostClient so it can be shared\\nbetween multiple unrelated
users. The factory keeps track of references to\\nservice discovery and shuts
down the client when not used.\\n\\nBUG=\\n\\nReview URL:
https://chromiumcodereview.appspot.com/22449004\", \"files\": [{\"name\":
\"chrome/browser/local_discovery/service_discovery_host_client.cc\", \"url\":
null}, {\"name\":
\"chrome/browser/local_discovery/service_discovery_host_client.h\", \"url\":
null}, {\"name\":
\"chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc\",
\"url\": null}], \"number\": 102628, \"project\": \"\", \"properties\": [],
\"repository\": \"svn://svn-mirror.golo.chromium.org/chrome/trunk\", \"rev\":
\"218091\", \"revision\": \"218091\", \"revlink\":
\"http://src.chromium.org/viewvc/chrome?view=rev&revision=218091\", \"when\":
1376688012, \"who\": \"noamsml@chromium.org\"}, {\"at\": \"Fri 16 Aug 2013
14:20:12\", \"branch\": \"src\", \"category\": null, \"comments\": \"<webview>:
Fix ptr access crash on browser plugin + interstitial teardown.\\n\\nIf browser
plugin loaded an interstitial page as view contents\\n(e.g. loading plugin
resulted in ssl-error), upon closing the\\ncontaining app, the interstitial
would try to show back\\n(RenderWidgetHostView::WasShown) the original contents
of the\\nRWHViewGuest, whose render_view_host_ was already in the middle
of\\ndestruction. We record the destruction phase and avoid calling methods\\non
RenderViewHost in this case.\\n\\nBUG=270313\\nTEST=chrome app <webview>, load a
guest pointing a page that results in\\nssl-error page showing (Proceed to
safety page, etc), close the app. The app\\nwould crash without this
change.\\nAdded regression test.\\n\\nReview URL:
https://chromiumcodereview.appspot.com/23004002\", \"files\": [{\"name\":
\"chrome/browser/apps/web_view_browsertest.cc\", \"url\": null}, {\"name\":
\"chrome/test/data/extensions/platform_apps/web_view/interstitial_teardown\",
\"url\": null}, {\"name\":
\"chrome/test/data/extensions/platform_apps/web_view/interstitial_teardown/embedder.js\",
\"url\": null}, {\"name\":
\"chrome/test/data/extensions/platform_apps/web_view/interstitial_teardown/https_page.html\",
\"url\": null}, {\"name\":
\"chrome/test/data/extensions/platform_apps/web_view/interstitial_teardown/main.html\",
\"url\": null}, {\"name\":
\"chrome/test/data/extensions/platform_apps/web_view/interstitial_teardown/manifest.json\",
\"url\": null}, {\"name\":
\"chrome/test/data/extensions/platform_apps/web_view/interstitial_teardown/test.js\",
\"url\": null}, {\"name\":
\"content/browser/browser_plugin/browser_plugin_guest.cc\", \"url\": null},
{\"name\": \"content/browser/browser_plugin/browser_plugin_guest.h\", \"url\":
null}, {\"name\":
\"content/browser/renderer_host/render_widget_host_view_guest.cc\", \"url\":
null}], \"number\": 102629, \"project\": \"\", \"properties\": [],
\"repository\": \"svn://svn-mirror.golo.chromium.org/chrome/trunk\", \"rev\":
\"218092\", \"revision\": \"218092\", \"revlink\":
\"http://src.chromium.org/viewvc/chrome?view=rev&revision=218092\", \"when\":
1376688012, \"who\": \"lazyboy@chromium.org\"}, {\"at\": \"Fri 16 Aug 2013
14:25:12\", \"branch\": \"src\", \"category\": null, \"comments\": \"Add a
priority parameter for HostResolver::RequestInfo's constructor\\n\\nUse
DEFAULT_PRIORITY when there isn't already a priority\\navailable.\\n\\nThis has
the net effect of changing the priority of\\nhost resolver requests that didn't
specify one from\\nMEDIUM to DEFAULT_PRIORITY (= LOWEST). This is okay,\\nas
those requests apparently didn't care what priority\\nthey
wanted.\\n\\nBUG=166689\\nTBR=mmenke@chromium.org\\n\\nReview URL:
https://codereview.chromium.org/23146004\", \"files\": [{\"name\":
\"chrome/browser/devtools/tethering_adb_filter.cc\", \"url\": null}, {\"name\":
\"chrome/browser/extensions/api/dns/dns_api.cc\", \"url\": null}, {\"name\":
\"chrome/browser/extensions/api/socket/socket_api.cc\", \"url\": null},
{\"name\": \"chrome/browser/net/network_stats.cc\", \"url\": null}, {\"name\":
\"chrome/browser/net/predictor.cc\", \"url\": null}, {\"name\":
\"content/browser/renderer_host/p2p/socket_dispatcher_host.cc\", \"url\": null},
{\"name\":
\"content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.cc\",
\"url\": null}, {\"name\":
\"content/browser/renderer_host/pepper/pepper_tcp_socket.cc\", \"url\": null},
{\"name\": \"net/dns/host_resolver.cc\", \"url\": null}, {\"name\":
\"net/dns/host_resolver.h\", \"url\": null}, {\"name\":
\"net/dns/host_resolver_impl_unittest.cc\", \"url\": null}, {\"name\":
\"net/dns/mapped_host_resolver_unittest.cc\", \"url\": null}, {\"name\":
\"net/dns/single_request_host_resolver_unittest.cc\", \"url\": null}, {\"name\":
\"net/ftp/ftp_network_transaction.cc\", \"url\": null}, {\"name\":
\"net/http/http_auth_handler_negotiate.cc\", \"url\": null}, {\"name\":
\"net/http/http_network_transaction_unittest.cc\", \"url\": null}, {\"name\":
\"net/proxy/proxy_resolver_v8_tracing.cc\", \"url\": null}, {\"name\":
\"net/quic/quic_network_transaction_unittest.cc\", \"url\": null}, {\"name\":
\"net/quic/quic_stream_factory.cc\", \"url\": null}, {\"name\":
\"net/socket/socks5_client_socket_unittest.cc\", \"url\": null}, {\"name\":
\"net/socket/socks_client_socket_pool.cc\", \"url\": null}, {\"name\":
\"net/socket/socks_client_socket_unittest.cc\", \"url\": null}, {\"name\":
\"net/socket/ssl_client_socket_pool_unittest.cc\", \"url\": null}, {\"name\":
\"net/socket/transport_client_socket_pool.cc\", \"url\": null}, {\"name\":
\"net/socket/transport_client_socket_pool.h\", \"url\": null}, {\"name\":
\"net/socket/transport_client_socket_unittest.cc\", \"url\": null}, {\"name\":
\"net/socket_stream/socket_stream.cc\", \"url\": null}, {\"name\":
\"net/spdy/spdy_session_pool.cc\", \"url\": null}, {\"name\":
\"net/spdy/spdy_session_pool_unittest.cc\", \"url\": null}, {\"name\":
\"net/spdy/spdy_session_unittest.cc\", \"url\": null}, {\"name\":
\"net/test/spawned_test_server/base_test_server.cc\", \"url\": null}, {\"name\":
\"net/tools/gdig/gdig.cc\", \"url\": null}], \"number\": 102630, \"project\":
\"\", \"properties\": [], \"repository\":
\"svn://svn-mirror.golo.chromium.org/chrome/trunk\", \"rev\": \"218093\",
\"revision\": \"218093\", \"revlink\":
\"http://src.chromium.org/viewvc/chrome?view=rev&revision=218093\", \"when\":
1376688312, \"who\": \"akalin@chromium.org\"}, {\"at\": \"Fri 16 Aug 2013
14:29:12\", \"branch\": \"src\", \"category\": null, \"comments\": \"Native
messaging support for service accounts.\\n\\nThis is an alternative
implementation of https://codereview.chromium.org/19670021/ . This version
performs the OAuth token exchange steps from inside the NativeMessaging host.
This means that the client secret and the service account access token never
leave the native messaging host.\\n\\nSince the API keys are also needed to use
the refresh token, this means that only the host binaries are able to get an
access token for the service account.\\n\\nBUG=224742\\n\\nReview URL:
https://chromiumcodereview.appspot.com/22769002\", \"files\": [{\"name\":
\"remoting/host/setup/native_messaging_host.cc\", \"url\": null}, {\"name\":
\"remoting/host/setup/native_messaging_host.h\", \"url\": null}, {\"name\":
\"remoting/host/setup/native_messaging_host_unittest.cc\", \"url\": null},
{\"name\": \"remoting/host/setup/oauth_client.cc\", \"url\": null}, {\"name\":
\"remoting/host/setup/oauth_client.h\", \"url\": null}, {\"name\":
\"remoting/remoting.gyp\", \"url\": null}, {\"name\":
\"remoting/webapp/host_controller.js\", \"url\": null}, {\"name\":
\"remoting/webapp/host_dispatcher.js\", \"url\": null}, {\"name\":
\"remoting/webapp/host_native_messaging.js\", \"url\": null}], \"number\":
102631, \"project\": \"\", \"properties\": [], \"repository\":
\"svn://svn-mirror.golo.chromium.org/chrome/trunk\", \"rev\": \"218094\",
\"revision\": \"218094\", \"revlink\":
\"http://src.chromium.org/viewvc/chrome?view=rev&revision=218094\", \"when\":
1376688552, \"who\": \"rmsousa@chromium.org\"}], \"from_addr\":
\"buildbot@chromium.org\", \"number\": 54475, \"project_name\": \"Chromium\",
\"reason\": \"scheduler\", \"recipients\": [\"vabr@google.com\",
\"lazyboy@chromium.org\", \"akalin@chromium.org\", \"noamsml@chromium.org\",
\"creis@google.com\", \"rmsousa@chromium.org\", \"brianderson@google.com\"],
\"result\": 5, \"revisions\": [\"218091\", \"218092\", \"218093\", \"218094\"],
\"steps\": [{\"logs\": [[\"stdio\",
\"http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/54475/steps/update_scripts/logs/stdio\"],
[\"interrupt\",
\"http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/54475/steps/update_scripts/logs/interrupt\"]],
\"name\": \"update_scripts\", \"results\": 5, \"started\": true, \"text\":
[\"update_scripts\", \"exception\", \"slave\", \"lost\"], \"urls\": {}},
{\"logs\": [], \"name\": \"gclient_revert\", \"results\": null, \"started\":
false, \"text\": [], \"urls\": {}}, {\"logs\": [], \"name\": \"update\",
\"results\": null, \"started\": false, \"text\": [], \"urls\": {}}, {\"logs\":
[], \"name\": \"runhooks\", \"results\": null, \"started\": false, \"text\": [],
\"urls\": {}}, {\"logs\": [], \"name\": \"cleanup_temp\", \"results\": null,
\"started\": false, \"text\": [], \"urls\": {}}, {\"logs\": [], \"name\":
\"compile\", \"results\": null, \"started\": false, \"text\": [], \"urls\": {}},
{\"logs\": [], \"name\": \"archive_build\", \"results\": null, \"started\":
false, \"text\": [], \"urls\": {}}, {\"logs\": [], \"name\": \"upload\",
\"results\": null, \"started\": false, \"text\": [], \"urls\": {}}, {\"logs\":
[], \"name\": \"check_deps2git\", \"results\": null, \"started\": false,
\"text\": [], \"urls\": {}}, {\"logs\": [], \"name\": \"check_deps2submodules\",
\"results\": null, \"started\": false, \"text\": [], \"urls\": {}}, {\"logs\":
[], \"name\": \"sizes\", \"results\": null, \"started\": false, \"text\": [],
\"urls\": {}}], \"unsatisfied\": [\"check_deps2git\", \"sizes\",
\"update_scripts\", \"update\", \"compile\", \"gclient_revert\",
\"archive_build\", \"runhooks\"], \"waterfall_url\":
\"http://build.chromium.org/p/chromium\"}", "hmac-sha256":
"a65b569399932e8ce7bb0421cddbee285efeb8b05ee92b745f050a3835aad8f4", "salt":
2649136503, "time": 1377132926}
On 2013/12/20 22:39:00, stip wrote:
> diff is that waterfall_url went from
> http://build.chromium.org/p/chromium/waterfall to
> http://build.chromium.org/p/chromium

Haha holy crap thanks for the helpful comment. Any chance this json could be
pretty printed?

Powered by Google App Engine
This is Rietveld 408576698