Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 1184423002: Add signcla verifier to Blink (Closed)

Created:
4 years, 10 months ago by sheyang
Modified:
4 years, 10 months ago
Reviewers:
Sergiy Byelozyorov
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add signcla verifier to Blink NOTRY=true BUG=457428 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197186

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M infra/config/cq.cfg View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
sheyang
4 years, 10 months ago (2015-06-16 17:02:42 UTC) #2
Sergiy Byelozyorov
lgtm w/ nits https://codereview.chromium.org/1184423002/diff/1/infra/config/cq.cfg File infra/config/cq.cfg (right): https://codereview.chromium.org/1184423002/diff/1/infra/config/cq.cfg#newcode156 infra/config/cq.cfg:156: sign_cla {} nit: please add an ...
4 years, 10 months ago (2015-06-16 17:34:11 UTC) #3
sheyang
https://codereview.chromium.org/1184423002/diff/1/infra/config/cq.cfg File infra/config/cq.cfg (right): https://codereview.chromium.org/1184423002/diff/1/infra/config/cq.cfg#newcode156 infra/config/cq.cfg:156: sign_cla {} On 2015/06/16 17:34:11, Sergiy Byelozyorov wrote: > ...
4 years, 10 months ago (2015-06-16 17:40:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184423002/20001
4 years, 10 months ago (2015-06-16 17:57:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184423002/20001
4 years, 10 months ago (2015-06-16 19:25:45 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-16 19:29:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197186

Powered by Google App Engine
This is Rietveld 408576698