Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1184413005: Clean up some CSSPropertyID helpers (Closed)

Created:
5 years, 6 months ago by rwlbuis
Modified:
5 years, 6 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, krit, blink-reviews-style_chromium.org, blink-reviews-css, kouhei+svg_chromium.org, fs, dglazkov+blink, apavlov+blink_chromium.org, darktears, gyuyoung2, f(malita), Stephen Chennney, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Clean up some CSSPropertyID helpers Move unresolvedCSSPropertyID/cssPropertyID declarations to CSSPropertyNames generated files, and remove the CSSParserString overload for unresolvedCSSPropertyID. BUG=489144 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197568

Patch Set 1 #

Total comments: 1

Patch Set 2 : Bring back CSSParserString overload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M Source/build/scripts/make_css_property_names.py View 2 chunks +9 lines, -0 lines 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSParser.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
rwlbuis
PTAL, just a cleanup I stumbled on.
5 years, 6 months ago (2015-06-17 22:38:16 UTC) #2
Timothy Loh
https://codereview.chromium.org/1184413005/diff/1/Source/core/css/parser/CSSPropertyParser.h File Source/core/css/parser/CSSPropertyParser.h (left): https://codereview.chromium.org/1184413005/diff/1/Source/core/css/parser/CSSPropertyParser.h#oldcode382 Source/core/css/parser/CSSPropertyParser.h:382: CSSPropertyID unresolvedCSSPropertyID(const CSSParserString&); Probably shouldn't remove this otherwise we'll ...
5 years, 6 months ago (2015-06-18 03:10:52 UTC) #3
rwlbuis
On 2015/06/18 03:10:52, Timothy Loh wrote: > https://codereview.chromium.org/1184413005/diff/1/Source/core/css/parser/CSSPropertyParser.h > File Source/core/css/parser/CSSPropertyParser.h (left): > > https://codereview.chromium.org/1184413005/diff/1/Source/core/css/parser/CSSPropertyParser.h#oldcode382 ...
5 years, 6 months ago (2015-06-18 15:03:09 UTC) #4
Timothy Loh
lgtm
5 years, 6 months ago (2015-06-22 01:39:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184413005/20001
5 years, 6 months ago (2015-06-22 10:43:47 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 11:42:09 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197568

Powered by Google App Engine
This is Rietveld 408576698