Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 1184413003: Relax the braces style checker to allow either {} or { }. (Closed)

Created:
4 years, 10 months ago by Jeffrey Yasskin
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@pinned
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Relax the {} check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M Tools/Scripts/webkitpy/style/checkers/cpp.py View 1 1 chunk +1 line, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184413003/1
4 years, 10 months ago (2015-06-16 18:57:31 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/66898)
4 years, 10 months ago (2015-06-16 19:40:11 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184413003/20001
4 years, 10 months ago (2015-06-16 20:08:34 UTC) #6
Jeffrey Yasskin
Please add in whoever should actually make the decision about whether this goes in. Thanks!
4 years, 10 months ago (2015-06-16 20:13:51 UTC) #8
leviw_travelin_and_unemployed
I'm not sure who's in charge of this train, but lgtm.
4 years, 10 months ago (2015-06-16 20:19:20 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-16 23:54:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184413003/20001
4 years, 10 months ago (2015-06-18 00:06:59 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 02:23:51 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197307

Powered by Google App Engine
This is Rietveld 408576698