Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1184403004: Templatize extractSelectedText used by FrameSelection function (Closed)

Created:
5 years, 6 months ago by yosin_UTC9
Modified:
5 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, hajimehoshi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Templatize extractSelectedText used by FrameSelection function This patch introduces a template function |extractSelectedTextAlgorithm<Strategy>| to makes |extractSelectedText()| function used by |FrameSeleciton| to work both on DOM tree and composed tree via |Strategy| template parameter. This patch is result of collaboration work with hajimehoshi@chromium.org for selection of web components. After this patch, we are going to implement another strategies for the composed tree. We've already prepared that at http://crrev.com/1106433002. BUG=275851 TEST=n/a; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M Source/core/editing/FrameSelection.cpp View 1 chunk +14 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 6 months ago (2015-06-18 07:29:55 UTC) #2
tkent
lgtm
5 years, 6 months ago (2015-06-18 07:49:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184403004/1
5 years, 6 months ago (2015-06-18 07:50:00 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 07:54:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197329

Powered by Google App Engine
This is Rietveld 408576698