Offer Resource Timing in workers

Source/core/fetch/ResourceFetcher.cpp

Index: Source/core/fetch/ResourceFetcher.cpp
diff --git a/Source/core/fetch/ResourceFetcher.cpp b/Source/core/fetch/ResourceFetcher.cpp
index 8fdd96d46d063bc213f206260b9e155acb3e8638..2a3914e402fa4f165117942c38488ec9af9d36e0 100644
--- a/Source/core/fetch/ResourceFetcher.cpp
+++ b/Source/core/fetch/ResourceFetcher.cpp
@@ -35,13 +35,13 @@
 #include "core/fetch/ResourceLoader.h"
 #include "core/fetch/ResourceLoaderSet.h"
 #include "core/fetch/UniqueIdentifier.h"
-#include "core/timing/ResourceTimingInfo.h"
 #include "platform/Logging.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/TraceEvent.h"
 #include "platform/TracedValue.h"
 #include "platform/mhtml/ArchiveResource.h"
 #include "platform/mhtml/ArchiveResourceCollection.h"
+#include "platform/network/ResourceTimingInfo.h"
 #include "platform/weborigin/KnownPorts.h"
 #include "platform/weborigin/SecurityOrigin.h"
 #include "platform/weborigin/SecurityPolicy.h"
@@ -468,8 +468,6 @@ ResourcePtr<Resource> ResourceFetcher::createResourceForLoading(FetchRequest& re
 
 void ResourceFetcher::storeResourceTimingInitiatorInformation(Resource* resource)
 {
-    if (resource->options().requestInitiatorContext != DocumentContext)
-        return;
     if (resource->options().initiatorInfo.name == FetchInitiatorTypeNames::internal)
         return;
 
@@ -812,7 +810,10 @@ void ResourceFetcher::didFinishLoading(Resource* resource, double finishTime, in
             OwnPtr<ResourceTimingInfo> info = it->value.release();
             m_resourceTimingInfoMap.remove(it);
             populateResourceTiming(info.get(), resource, false);
-            context().addResourceTiming(*info);
+            if (resource->options().requestInitiatorContext == DocumentContext)
+                context().addResourceTiming(*info);
+            else
+                resource->reportResourceTimingToWorker(*info);

[kinuko, 2015/06/23 05:09:50]

I'm wondering if we could rather make it general to both worker and document?
(From Resource's pov it's basically just about exposing resource timing info to
its client, it doesn't seem to need to know about Worker)

Putting aside all gotcha my preference is:

Resource has a method like: reportResourceTimingToClients()
  we could have a default impl which sends timing info to clients
ResourceClient has a method like: didReceiveResourceTiming()
  which could have a default impl for Document case
DocumentThreadableLoader overrides it

Also: please help me understand a bit more: for worker case is RawResource the
only resource we want to care about, or would we need to implement it in other
resource/resourceclient someday?

[Kunihiko Sakamoto, 2015/06/23 06:47:34]

Yeah I tried to unify worker / document path, but couldn't come up with an
elegant way to do so.
Thanks for the naming suggestion. Renamed the methods in that manner.
Now Resource doesn't care about worker, so reportResourceTimingToClients is
called unconditionally and only DocumentThreadableLoader handles it.
We only need to care about RawResource as long as all worker-initiated requests
use DocumentThreadableLoader, since DocumentThreadableLoader treats every
resource as RawResource.

         }
     }
     context().dispatchDidFinishLoading(resource->identifier(), finishTime, encodedDataLength);