Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1184373002: [parser] parse `CalllExpression TemplateLiteral` production (Closed)

Created:
5 years, 6 months ago by caitp (gmail)
Modified:
5 years, 6 months ago
CC:
v8-dev, mike4
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] parse `CalllExpression TemplateLiteral` production BUG=v8:4183 R=arv@chromium.org, rossberg@chromium.org LOG=N Committed: https://crrev.com/6d22f7a7945f5c7371419d64753b9beeaafd71c6 Cr-Commit-Position: refs/heads/master@{#29055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M src/preparser.h View 1 chunk +7 lines, -0 lines 0 comments Download
M test/mjsunit/es6/templates.js View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
caitp (gmail)
PTAL
5 years, 6 months ago (2015-06-16 13:21:29 UTC) #1
arv (Not doing code reviews)
LGTM
5 years, 6 months ago (2015-06-16 16:39:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184373002/1
5 years, 6 months ago (2015-06-16 17:36:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 18:08:27 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 18:08:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d22f7a7945f5c7371419d64753b9beeaafd71c6
Cr-Commit-Position: refs/heads/master@{#29055}

Powered by Google App Engine
This is Rietveld 408576698