Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1184343002: Recursive operation delegate continues operations with ignoring errors. (Closed)

Created:
5 years, 6 months ago by yawano
Modified:
5 years, 6 months ago
Reviewers:
tzik
CC:
chromium-reviews, darin-cc_chromium.org, jam, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Recursive operation delegate continues operations with ignoring errors. Previously recursive operation delegate aborted its operation while an error has happened. This CL adds a method to run a recursive operation with ignoring errors. BUG=499642 TEST=content_unittests:RecursiveOperationDelegateTest.* Committed: https://crrev.com/fbdc39ddba07a973c23779f3caa7e110e3e22a52 Cr-Commit-Position: refs/heads/master@{#334783}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -17 lines) Patch
M content/browser/fileapi/recursive_operation_delegate_unittest.cc View 5 chunks +121 lines, -0 lines 0 comments Download
M storage/browser/fileapi/file_system_operation.h View 1 chunk +6 lines, -0 lines 0 comments Download
M storage/browser/fileapi/recursive_operation_delegate.h View 5 chunks +20 lines, -1 line 0 comments Download
M storage/browser/fileapi/recursive_operation_delegate.cc View 4 chunks +47 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL. Thank you!
5 years, 6 months ago (2015-06-16 11:19:48 UTC) #2
tzik
lgtm
5 years, 6 months ago (2015-06-17 05:52:09 UTC) #3
yawano
On 2015/06/17 05:52:09, tzik wrote: > lgtm Thank you!
5 years, 6 months ago (2015-06-17 06:02:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184343002/1
5 years, 6 months ago (2015-06-17 06:03:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 06:54:30 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 06:56:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbdc39ddba07a973c23779f3caa7e110e3e22a52
Cr-Commit-Position: refs/heads/master@{#334783}

Powered by Google App Engine
This is Rietveld 408576698