Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: Source/devtools/front_end/timeline/TimelineEventOverview.js

Issue 1184333003: DevTools: Move frame rate overview timeline out of experiment. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/main/Main.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TimelineEventOverview.js
diff --git a/Source/devtools/front_end/timeline/TimelineEventOverview.js b/Source/devtools/front_end/timeline/TimelineEventOverview.js
index 355f39058c85c7f501c641ad4daeebaafedd79c9..64cbb4fd606b25baeacd7173bb0a5afe3c72bd35 100644
--- a/Source/devtools/front_end/timeline/TimelineEventOverview.js
+++ b/Source/devtools/front_end/timeline/TimelineEventOverview.js
@@ -77,7 +77,7 @@ WebInspector.TimelineEventOverview.prototype = {
var threads = this._model.virtualThreads();
var mainThreadEvents = this._model.mainThreadEvents();
var networkHeight = this._canvas.clientHeight
- - WebInspector.TimelineEventOverview._fullStripHeight
+ - 2 * WebInspector.TimelineEventOverview._fullStripHeight
- 2 * WebInspector.TimelineEventOverview._smallStripHeight;
var position = 0;
if (Runtime.experiments.isEnabled("inputEventsOnTimelineOverview")) {
@@ -85,8 +85,6 @@ WebInspector.TimelineEventOverview.prototype = {
position += inputHeight;
networkHeight -= inputHeight;
}
- if (Runtime.experiments.isEnabled("frameRateOnEventsOverview"))
- networkHeight -= WebInspector.TimelineEventOverview._fullStripHeight;
position += this._drawNetwork(mainThreadEvents, position, networkHeight);
position += this._drawStackedUtilizationChart(mainThreadEvents, position, WebInspector.TimelineEventOverview._fullStripHeight);
for (var thread of threads.filter(function(thread) { return !thread.isWorker(); }))
@@ -95,8 +93,7 @@ WebInspector.TimelineEventOverview.prototype = {
for (var thread of threads.filter(function(thread) { return thread.isWorker(); }))
this._drawEvents(thread.events, position, WebInspector.TimelineEventOverview._smallStripHeight);
position += WebInspector.TimelineEventOverview._smallStripHeight;
- if (Runtime.experiments.isEnabled("frameRateOnEventsOverview"))
- position += this._drawFrames(position, WebInspector.TimelineEventOverview._fullStripHeight);
+ position += this._drawFrames(position, WebInspector.TimelineEventOverview._fullStripHeight);
console.assert(position === this._canvas.clientHeight);
},
« no previous file with comments | « Source/devtools/front_end/main/Main.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698