Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1460)

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 1184303003: Ignore overflow clip on root layer if HitTestRequest::IgnoreClipping is set. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/tests/WebFrameTest.cpp
diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp
index 1208021f7abebdf6548dd1789490172c44c63c5e..69323e64c9e836695639e60b37cfea1b517e4771 100644
--- a/Source/web/tests/WebFrameTest.cpp
+++ b/Source/web/tests/WebFrameTest.cpp
@@ -2472,7 +2472,7 @@ TEST_P(ParameterizedWebFrameTest, DivAutoZoomWideDivTest)
EXPECT_FLOAT_EQ(webViewHelper.webViewImpl()->minimumPageScaleFactor(), scale);
}
-TEST_F(WebFrameTest, DivAutoZoomVeryTallTest)
+TEST_P(ParameterizedWebFrameTest, DivAutoZoomVeryTallTest)
{
// When a block is taller than the viewport and a zoom targets a lower part
// of it, then we should keep the target point onscreen instead of snapping
@@ -2482,7 +2482,7 @@ TEST_F(WebFrameTest, DivAutoZoomVeryTallTest)
const float deviceScaleFactor = 2.0f;
int viewportWidth = 640 / deviceScaleFactor;
int viewportHeight = 1280 / deviceScaleFactor;
- FrameTestHelpers::WebViewHelper webViewHelper;
+ FrameTestHelpers::WebViewHelper webViewHelper(this);
webViewHelper.initializeAndLoad(m_baseURL + "very_tall_div.html", true, 0, 0, configureAndroid);
webViewHelper.webView()->resize(WebSize(viewportWidth, viewportHeight));
webViewHelper.webView()->setDeviceScaleFactor(deviceScaleFactor);
@@ -2770,11 +2770,11 @@ TEST_F(WebFrameTest, DivAutoZoomScaleFontScaleFactorTest)
EXPECT_FLOAT_EQ(legibleScale, scale);
}
-TEST_F(WebFrameTest, BlockBoundTest)
+TEST_P(ParameterizedWebFrameTest, BlockBoundTest)
{
registerMockedHttpURLLoad("block_bound.html");
- FrameTestHelpers::WebViewHelper webViewHelper;
+ FrameTestHelpers::WebViewHelper webViewHelper(this);
webViewHelper.initializeAndLoad(m_baseURL + "block_bound.html", false, 0, 0, configureAndroid);
IntRect rectBack = IntRect(0, 0, 200, 200);
« Source/core/layout/ClipRectsCache.h ('K') | « Source/core/paint/DeprecatedPaintLayerClipper.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698