Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 1184303003: Ignore overflow clip on root layer if HitTestRequest::IgnoreClipping is set. (Closed)

Created:
4 years, 10 months ago by skobes
Modified:
4 years, 10 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, szager1, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Ignore overflow clip on root layer if HitTestRequest::IgnoreClipping is set. Previously, DeprecatedPaintLayer::hitTest could choose whether to clip to the viewport by simply passing the appropriate hitTestRect param to hitTestLayer. But with root layer scrolling, the viewport clip is reflected in the clip rects computed by DeprecatedPaintLayerClipper which are cached and propagated down the layer tree, so it is harder to ignore. This change teaches DeprecatedPaintLayerClipper how to ignore the viewport clip. BUG=499053 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197214

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -17 lines) Patch
M Source/core/layout/ClipRectsCache.h View 1 chunk +1 line, -0 lines 1 comment Download
M Source/core/paint/DeprecatedPaintLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.cpp View 5 chunks +9 lines, -8 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerClipper.h View 3 chunks +4 lines, -0 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerClipper.cpp View 4 chunks +19 lines, -4 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
skobes
4 years, 10 months ago (2015-06-16 22:57:48 UTC) #2
esprehn
lgtm, can you expand the description some about why you need to do this. Sad ...
4 years, 10 months ago (2015-06-16 23:02:02 UTC) #3
skobes
On 2015/06/16 23:02:02, esprehn wrote: > lgtm, can you expand the description some about why ...
4 years, 10 months ago (2015-06-16 23:28:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184303003/1
4 years, 10 months ago (2015-06-16 23:29:28 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-17 00:39:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197214

Powered by Google App Engine
This is Rietveld 408576698