Issue 1184303002: Refactoring: Introduce StyledMarkupSerializer::shouldAnnotate()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1184303002: Refactoring: Introduce StyledMarkupSerializer::shouldAnnotate() (Closed)

Created:
4 years, 10 months ago by hajimehoshi

Modified:
4 years, 10 months ago

Reviewers:
yosin_UTC9

CC:
blink-reviews, blink-reviews-style_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Refactoring: Introduce StyledMarkupSerializer::shouldAnnotate() This CL introduces StyledMarkupSerializer::shouldAnnotate() and replaces repeated code with this. This CL is a split of crrev.com/1177323005 BUG=n/a TEST=n/a; no behavior change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197167

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	Source/core/editing/StyledMarkupSerializer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/core/editing/StyledMarkupSerializer.cpp	View		4 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184303002/1

4 years, 10 months ago (2015-06-16 08:53:07 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-16 09:59:34 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197167

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages