Add SetUploadDataStream method to URLFetcher.

net/url_request/test_url_fetcher_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/test_url_fetcher_factory.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop.h"
 #include "net/base/host_port_pair.h"
+#include "net/base/upload_data_stream.h"
 #include "net/http/http_response_headers.h"
 #include "net/url_request/url_fetcher_delegate.h"
 #include "net/url_request/url_fetcher_impl.h"
 #include "net/url_request/url_request_status.h"
 
 namespace net {
 
 ScopedURLFetcherFactory::ScopedURLFetcherFactory(
     URLFetcherFactory* factory) {
   DCHECK(!URLFetcherImpl::factory());
@@ skipping 21 matching lines @@
       fake_max_retries_(0) {
 }
 
 TestURLFetcher::~TestURLFetcher() {
   if (delegate_for_tests_)
     delegate_for_tests_->OnRequestEnd(id_);
   if (owner_)
     owner_->RemoveFetcherFromMap(id_);
 }
 
+void TestURLFetcher::SetUploadDataStream(
+    const std::string& upload_content_type,
+    scoped_ptr<UploadDataStream> upload_content) {
+  upload_data_stream_ = upload_content.Pass();
+}
+
 void TestURLFetcher::SetUploadData(const std::string& upload_content_type,
                                    const std::string& upload_content) {
   upload_data_ = upload_content;

[hashimoto, 2013/01/11 06:07:38]

Having both upload_data_stream_ and upload_data_ seems confusing.
How about completely replacing upload_data_ with upload_data_stream_, or mark
SetUploadDataStream as NOTIMPLEMENTED?

[mattm, 2013/01/11 21:42:02]

Thought about that, but wasn't entirely sure what the desired use case of this
class is.  If the test code actually wants to be able to distinguish whether the
caller used SetUploadData or SetUploadDataStream, then having them separately
would make sense.  Also this would make implementing the upload_data() accessor
harder.

[hashimoto, 2013/01/15 06:59:28]

I see.  Seems all users of this method just want to verify the correct value is
set as the upload data.
(http://code.google.com/p/chromium/source/search?q=\bupload_data\()

 }
 
 void TestURLFetcher::SetChunkedUpload(const std::string& upload_content_type) {
 }
 
 void TestURLFetcher::AppendChunkToUpload(const std::string& data,
                                          bool is_last_chunk) {
   DCHECK(!did_receive_last_chunk_);
   did_receive_last_chunk_ = is_last_chunk;
   chunks_.push_back(data);
@@ skipping 295 matching lines @@
 
 URLFetcher* URLFetcherImplFactory::CreateURLFetcher(
     int id,
     const GURL& url,
     URLFetcher::RequestType request_type,
     URLFetcherDelegate* d) {
   return new URLFetcherImpl(url, request_type, d);
 }
 
 }  // namespace net