Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1184233002: Exit with -sig when handling signals. (Closed)

Created:
5 years, 6 months ago by rickyz (no longer on Chrome)
Modified:
5 years, 6 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Exit with -sig when handling signals. This is more consistent with the behavior in src/trusted/service_runtime/nacl_signal_common.c. BUG= http://code.google.com/p/chromium/issues/detail?id=460972 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/0f50a4b61659b23188e27ab42485d265d3d063dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/nonsfi/linux/irt_exception_handling.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rickyz (no longer on Chrome)
5 years, 6 months ago (2015-06-16 00:28:18 UTC) #2
Mark Seaborn
LGTM
5 years, 6 months ago (2015-06-16 00:46:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184233002/1
5 years, 6 months ago (2015-06-16 00:48:21 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 02:38:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/0f50a4b61...

Powered by Google App Engine
This is Rietveld 408576698