Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 118423004: Add support for wrapping classes indirectly inherited from gin::Wrappable<T> (Closed)

Created:
7 years ago by Aaron Boodman
Modified:
7 years ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Add support for wrapping classes indirectly inherited from gin::Wrappable<T> This is needed for: https://codereview.chromium.org/116163008/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241730

Patch Set 1 #

Patch Set 2 : update StatsCollectionController #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -63 lines) Patch
M content/renderer/stats_collection_controller.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M content/renderer/stats_collection_controller.cc View 1 2 chunks +10 lines, -11 lines 0 comments Download
M gin/wrappable.h View 3 chunks +6 lines, -15 lines 0 comments Download
M gin/wrappable.cc View 2 chunks +9 lines, -16 lines 0 comments Download
M gin/wrappable_unittest.cc View 4 chunks +55 lines, -8 lines 0 comments Download
M mojo/apps/js/bindings/gl/context.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/apps/js/bindings/gl/context.cc View 2 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Aaron Boodman
7 years ago (2013-12-18 20:59:08 UTC) #1
jochen (gone - plz use gerrit)
why don't you need to change the two classes in content/renderer? gin_browsertests.cc and stats_collection_controller.cc
7 years ago (2013-12-18 21:03:41 UTC) #2
Aaron Boodman
Because I did not compile those o_0. On Wed, Dec 18, 2013 at 1:03 PM, ...
7 years ago (2013-12-18 21:05:55 UTC) #3
jochen (gone - plz use gerrit)
anyway, the wrappable change LGTM. Updating the content bits should be straight forward thanks for ...
7 years ago (2013-12-18 21:19:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/118423004/10001
7 years ago (2013-12-18 21:31:53 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-19 00:52:50 UTC) #6
Message was sent while issue was closed.
Change committed as 241730

Powered by Google App Engine
This is Rietveld 408576698