Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1184183003: Add use counter for ineligible Subresource Integrity use (Closed)

Created:
5 years, 6 months ago by jww
Modified:
5 years, 6 months ago
Reviewers:
Mike West
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add use counter for ineligible Subresource Integrtiy use This adds a counter to track how often an integrity attribute is used on a valid HTML tag, but for a resource load that is ineligible. Ineligible resources are those that are cross origin, but done without CORS. These loads are allowed, but not SRI check is done, and a console message is logged. R=mkwst@chromium.org BUG=355467 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197184

Patch Set 1 #

Patch Set 2 : Rebase on ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/frame/SubresourceIntegrity.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
jww
5 years, 6 months ago (2015-06-15 19:51:55 UTC) #1
Mike West
On 2015/06/15 at 19:51:55, jww wrote: > LGTM % s/Integrtiy/Integrity/ in the title of the ...
5 years, 6 months ago (2015-06-16 06:52:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184183003/1
5 years, 6 months ago (2015-06-16 16:48:31 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59099)
5 years, 6 months ago (2015-06-16 16:51:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184183003/20001
5 years, 6 months ago (2015-06-16 16:54:21 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=197184
5 years, 6 months ago (2015-06-16 17:56:31 UTC) #10
Mike West
On 2015/06/16 at 06:52:56, Mike West wrote: > On 2015/06/15 at 19:51:55, jww wrote: > ...
5 years, 6 months ago (2015-06-16 18:07:16 UTC) #11
Mike West
On 2015/06/16 at 18:07:16, Mike West wrote: > On 2015/06/16 at 06:52:56, Mike West wrote: ...
5 years, 6 months ago (2015-06-16 18:07:46 UTC) #12
jww
5 years, 6 months ago (2015-06-16 18:09:08 UTC) #13
Message was sent while issue was closed.
On 2015/06/16 18:07:46, Mike West wrote:
> On 2015/06/16 at 18:07:16, Mike West wrote:
> > On 2015/06/16 at 06:52:56, Mike West wrote:
> > > On 2015/06/15 at 19:51:55, jww wrote:
> > > > 
> > > 
> > > LGTM % s/Integrtiy/Integrity/ in the title of the CL's description. :)
> > 
> > It doesn't look like you fixed this before landing. :(
> 
> Oh, I see. You fixed the review's title, but not the text in the description.
> That's a confusing interface. :/

Oh my! You're completely correct; my bad. That is terrible :-(

Powered by Google App Engine
This is Rietveld 408576698