Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1184183002: Separate greedy regalloc in its own files (Closed)

Created:
5 years, 6 months ago by Mircea Trofin
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Separated the new register allocator in its own files. Opportunistically removed GreedyAllocator::TryReuseSpillForPhi because it is actually unsuitable for Greedy. It was copied from Linear and it relies on hints, however, the current implementation of hints assumes linear scan. This change doesn't aim to address performance nor correctness for Greedy. BUG= Committed: https://crrev.com/4e0b7b0cf5c591219ad1152a832123a9837eeecb Cr-Commit-Position: refs/heads/master@{#29054}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+550 lines, -591 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A src/compiler/greedy-allocator.h View 1 1 chunk +66 lines, -0 lines 0 comments Download
A src/compiler/greedy-allocator.cc View 1 chunk +460 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/register-allocator.h View 3 chunks +3 lines, -49 lines 0 comments Download
M src/compiler/register-allocator.cc View 9 chunks +16 lines, -542 lines 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Mircea Trofin
https://codereview.chromium.org/1184183002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1184183002/diff/1/BUILD.gn#newcode650 BUILD.gn:650: "src/compiler/greedy-allocator.h", I am actually not confident this change needs ...
5 years, 6 months ago (2015-06-15 21:55:28 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/1184183002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1184183002/diff/1/BUILD.gn#newcode650 BUILD.gn:650: "src/compiler/greedy-allocator.h", On 2015/06/15 21:55:28, Mircea Trofin wrote: > I ...
5 years, 6 months ago (2015-06-16 05:32:01 UTC) #3
Jarin
lgm with a nit. https://codereview.chromium.org/1184183002/diff/1/src/compiler/greedy-allocator.h File src/compiler/greedy-allocator.h (right): https://codereview.chromium.org/1184183002/diff/1/src/compiler/greedy-allocator.h#newcode63 src/compiler/greedy-allocator.h:63: } Missing comments for namespace ...
5 years, 6 months ago (2015-06-16 06:39:41 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184183002/1
5 years, 6 months ago (2015-06-16 06:39:41 UTC) #6
Jarin
I mean lgtm :-)
5 years, 6 months ago (2015-06-16 06:39:59 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-16 07:08:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184183002/20001
5 years, 6 months ago (2015-06-16 16:16:17 UTC) #12
Mircea Trofin
https://codereview.chromium.org/1184183002/diff/1/src/compiler/greedy-allocator.h File src/compiler/greedy-allocator.h (right): https://codereview.chromium.org/1184183002/diff/1/src/compiler/greedy-allocator.h#newcode63 src/compiler/greedy-allocator.h:63: } On 2015/06/16 06:39:40, jarin wrote: > Missing comments ...
5 years, 6 months ago (2015-06-16 16:16:25 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-16 17:10:21 UTC) #14
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 17:10:41 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e0b7b0cf5c591219ad1152a832123a9837eeecb
Cr-Commit-Position: refs/heads/master@{#29054}

Powered by Google App Engine
This is Rietveld 408576698