Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 1184153004: Bump up point where we switch to distance fields for large glyphs (Closed)

Created:
5 years, 6 months ago by jvanverth1
Modified:
5 years, 6 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Bump up point where we switch to distance fields for large glyphs This is hopefully a temporary fix. It's unclear why distance fields are so much slower on the N4 (and N7). BUG=chromium:467569 Committed: https://skia.googlesource.com/skia/+/0fce1fb02d93e66d42528f322f8aa4ca64ff0fb2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/gpu/GrAtlasTextContext.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
jvanverth1
5 years, 6 months ago (2015-06-16 14:57:43 UTC) #3
bsalomon
lgtm
5 years, 6 months ago (2015-06-16 15:00:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184153004/1
5 years, 6 months ago (2015-06-16 15:40:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/0fce1fb02d93e66d42528f322f8aa4ca64ff0fb2
5 years, 6 months ago (2015-06-16 15:46:28 UTC) #8
jvanverth1
5 years, 6 months ago (2015-06-17 20:06:29 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1178713005/ by jvanverth@google.com.

The reason for reverting is: Seeing some Nexus 4 perf regressions in individual
tests in Chromium that may be due to this change. This doesn't appear to be the
correct fix for the bug in any case..

Powered by Google App Engine
This is Rietveld 408576698