Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1184143011: nibless mac, visual bench working on mac (Closed)

Created:
5 years, 6 months ago by bsalomon
Modified:
5 years, 6 months ago
Reviewers:
joshualitt
CC:
review_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Allows windowed apps to be built on the Mac just by writing a SkOSWindow subclass without needing nib/plist files. Makes visualbench work on the Mac. Committed: https://skia.googlesource.com/skia/+/241b56db1d5c9d058dc316ad33b397be50428c4c

Patch Set 1 #

Patch Set 2 : updated #

Patch Set 3 : more gyp cleanup #

Patch Set 4 : cleanup #

Patch Set 5 : fix HelloWorld compile on windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -4201 lines) Patch
M gyp/SampleApp.gyp View 1 2 2 chunks +0 lines, -33 lines 0 comments Download
M gyp/SimpleCocoaApp.gyp View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
M gyp/example.gyp View 1 2 3 4 2 chunks +3 lines, -31 lines 0 comments Download
M gyp/v8.gyp View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
M gyp/views.gyp View 1 2 2 chunks +16 lines, -2 lines 0 comments Download
M gyp/visualbench.gyp View 1 2 2 chunks +0 lines, -29 lines 0 comments Download
M include/views/SkOSWindow_Mac.h View 1 chunk +3 lines, -4 lines 0 comments Download
D src/views/mac/SampleApp.xib View 1 2 1 chunk +0 lines, -3962 lines 0 comments Download
D src/views/mac/SampleApp-Info.plist View 1 2 1 chunk +0 lines, -34 lines 0 comments Download
D src/views/mac/SampleAppDelegate.h View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
D src/views/mac/SampleAppDelegate.mm View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M src/views/mac/SkNSView.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/views/mac/SkNSView.mm View 1 2 3 3 chunks +9 lines, -3 lines 0 comments Download
M src/views/mac/SkOSWindow_Mac.mm View 1 chunk +14 lines, -0 lines 0 comments Download
M src/views/mac/skia_mac.mm View 1 2 3 1 chunk +108 lines, -8 lines 0 comments Download
M tools/VisualBench.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184143011/60001
5 years, 6 months ago (2015-06-18 17:50:32 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 6 months ago (2015-06-18 17:50:33 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/1581) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 6 months ago (2015-06-18 17:56:08 UTC) #6
joshualitt
On 2015/06/18 17:56:08, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 6 months ago (2015-06-18 18:04:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184143011/80001
5 years, 6 months ago (2015-06-18 18:44:22 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 18:49:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/241b56db1d5c9d058dc316ad33b397be50428c4c

Powered by Google App Engine
This is Rietveld 408576698