Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1184143003: Remove CSSParserValue usage from StyleRuleKeyframe (Closed)

Created:
5 years, 6 months ago by rwlbuis
Modified:
5 years, 6 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove CSSParserValue usage from StyleRuleKeyframe Rather then replacing this with CSSParserToken, it seems it is not even used, so remove it. BUG=499780 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M Source/core/css/StyleRuleKeyframe.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/StyleRuleKeyframe.cpp View 2 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
5 years, 6 months ago (2015-06-15 18:13:01 UTC) #2
Timothy Loh
On 2015/06/15 18:13:01, rwlbuis wrote: > PTAL lgtm
5 years, 6 months ago (2015-06-15 23:44:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184143003/1
5 years, 6 months ago (2015-06-16 00:17:19 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 01:16:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197151

Powered by Google App Engine
This is Rietveld 408576698