move KeyUsageAllows to more logical place(part1)

move KeyUsageAllows to more logical place(part1)

move KeyUsageAllows to the class where its data is. That way the 
function and its contexts is much more understandable. 
This is first part, second part can be found here:
https://crrev.com/1181413009/

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201040

[Olli Raula, 2015-08-11 11:44:31]

olli.raula@intel.com changed reviewers:
+ eroman@chromium.org

[Olli Raula, 2015-08-11 11:45:58]

Could you review these?

[eroman, 2015-08-11 17:05:15]

https://codereview.chromium.org/1184123007/diff/20001/public/platform/WebCryp...
File public/platform/WebCryptoKey.h (right):

https://codereview.chromium.org/1184123007/diff/20001/public/platform/WebCryp...
public/platform/WebCryptoKey.h:123: BLINK_PLATFORM_EXPORT bool
KeyUsageAllows(const blink::WebCryptoKeyUsage) const;
The Blink style (which confusingly is different from the Chromium style) uses
lower-camel case, so this should be called:

   keyUsageAllows()

Other than that, looks good

[Olli Raula, 2015-08-12 08:04:30]

Thanks for review, fixed now.

[eroman, 2015-08-12 17:25:25]

eroman@chromium.org changed reviewers:
+ jochen@chromium.org

[eroman, 2015-08-12 17:25:25]

LGTM.

+jochen for OWNERS approval.


(Note this contributor is not yet in AUTHORS file, however is being added as
part of https://codereview.chromium.org/1181413009/. Not sure what the protocol
is for Blink commits, if they need to be in AUTHORS first...)

[eroman, 2015-08-21 20:04:56]

eroman@chromium.org changed reviewers:
+ adamk@chromium.org
- jochen@chromium.org

[eroman, 2015-08-21 20:04:57]

Changing reviewer from jochen --> adamk for OWNERS approval (jochen is on
vacation).

[adamk, 2015-08-21 20:57:40]

adamk@chromium.org changed reviewers:
+ pdr@chromium.org
- adamk@chromium.org

[adamk, 2015-08-21 20:57:41]

Maybe try pdr? I'm not an owner in public/

[pdr., 2015-08-21 21:05:06]

On 2015/08/21 at 20:57:41, adamk wrote:
> Maybe try pdr? I'm not an owner in public/

LGTM given that eroman is okay with the overall design.


For the AUTHORS file, as long as they have signed the CLA, my understanding is
we can happily take contributions. I double-checked and olli.raula@intel.com is
good to go.

[pdr., 2015-08-21 21:05:10]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2015-08-21 21:05:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1184123007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1184123007/40001

[commit-bot: I haz the power, 2015-08-22 01:34:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-22 01:34:18]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[pdr., 2015-08-22 05:28:11]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2015-08-22 05:28:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1184123007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1184123007/40001

[commit-bot: I haz the power, 2015-08-22 07:45:05]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201040