Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1184123002: Revert of make gm background colors 565 compatible (Closed)

Created:
5 years, 6 months ago by caryclark
Modified:
5 years, 6 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of make gm background colors 565 compatible (patchset #2 id:20001 of https://codereview.chromium.org/1176243006/) Reason for revert: breaks many bots with refcnt error Original issue's description: > make gm background colors 565 compatible > > Change a batch of GM tests to convert their background color > so that it is representable in 8888 and 565. > > Enable portable text in those same tests to minimize platform > differences. > > In a couple of bitmap tests, use portable typefaces instead of > choosing 'Times' which may or may not be available on the platform. > > R=borenet@google.com > > Committed: https://skia.googlesource.com/skia/+/be7f768a357aefb39c42d24b81b24d647bb6ab70 TBR=borenet@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/0bdb08b1ba8fbd18c4838f86a23f1ef4b3a3bfdf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -67 lines) Patch
M gm/anisotropic.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/arcofzorro.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bigblurs.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bigmatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bitmapcopy.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M gm/bitmapfilters.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/blurs.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bmpfilterqualityrepeat.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M gm/clipdrawdraw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/colormatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/complexclip3.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/constcolorprocessor.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M gm/dcshader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/downsamplebitmap.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M gm/drawlooper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/emptypath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/filltypes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/filterbitmap.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M gm/filterfastbounds.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/filterindiabox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gradientDirtyLaundry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gradient_matrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gradients.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/gradients_2pt_conical.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gradients_no_texture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/internal_links.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/modecolorfilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/nested.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/pathinterior.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/rrects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadertext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/shadertext2.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M gm/shadertext3.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/shadows.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/simpleaaclip.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/tinybitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/sk_tool_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/sk_tool_utils.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
caryclark
Created Revert of make gm background colors 565 compatible
5 years, 6 months ago (2015-06-15 12:27:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184123002/1
5 years, 6 months ago (2015-06-15 12:27:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/0bdb08b1ba8fbd18c4838f86a23f1ef4b3a3bfdf
5 years, 6 months ago (2015-06-15 12:28:03 UTC) #3
caryclark
5 years, 6 months ago (2015-06-15 13:50:51 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1182403003/ by caryclark@google.com.

The reason for reverting is: underlying problem with portable refs deleted more
than once fixed.

Powered by Google App Engine
This is Rietveld 408576698