Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 118410: We don't handle certificate errors during SSL renegotiation.... (Closed)

Created:
9 years, 8 months ago by wtc
Modified:
7 years, 9 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

We don't handle certificate errors during SSL renegotiation. In the common case, the server sends the same certificate during renegotiation. Since the certificate has been verified, we can assume the certificate is good or has been accepted by the user. If the server sends a different certificate that has an error, we need to return an error code that won't trigger our certificate error handling code, which doesn't handle this case correctly. Add the ERR_CERT_ERROR_IN_SSL_RENEGOTIATION error for this purpose. R=rvargas BUG=http://crbug.com/13226 TEST=See http://crbug.com/13226 comment 9 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17919

Patch Set 1 #

Total comments: 2

Patch Set 2 : Upload before checkin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -8 lines) Patch
M net/base/net_error_list.h View 1 chunk +7 lines, -0 lines 0 comments Download
M net/base/ssl_client_socket_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/ssl_client_socket_win.cc View 3 chunks +28 lines, -8 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
wtc
http://codereview.chromium.org/118410/diff/1/5 File net/base/ssl_client_socket_win.cc (left): http://codereview.chromium.org/118410/diff/1/5#oldcode729 Line 729: if (renegotiating_) { This block of code becomes ...
9 years, 8 months ago (2009-06-08 23:08:11 UTC) #1
rvargas (doing something else)
9 years, 8 months ago (2009-06-09 01:18:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698