Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 1184093004: Faster checks in polymorphic instance calls if Smi-s are involved (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: m Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_arm.cc
diff --git a/runtime/vm/intermediate_language_arm.cc b/runtime/vm/intermediate_language_arm.cc
index 7643408673a6ff4e040e945716749a2872b9325a..0f11dff206fe7a3630364cc2332641722b69ea56 100644
--- a/runtime/vm/intermediate_language_arm.cc
+++ b/runtime/vm/intermediate_language_arm.cc
@@ -5878,23 +5878,18 @@ void PolymorphicInstanceCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
return;
}
- // Load receiver into R0.
- __ LoadFromOffset(kWord, R0, SP,
- (instance_call()->ArgumentCount() - 1) * kWordSize);
-
Label* deopt = compiler->AddDeoptStub(
deopt_id(), ICData::kDeoptPolymorphicInstanceCallTestFail);
- LoadValueCid(compiler, R2, R0,
- (ic_data().GetReceiverClassIdAt(0) == kSmiCid) ? NULL : deopt);
-
+ Label ok;
compiler->EmitTestAndCall(ic_data(),
- R2, // Class id register.
instance_call()->ArgumentCount(),
instance_call()->argument_names(),
deopt,
+ &ok,
deopt_id(),
instance_call()->token_pos(),
locs());
+ __ Bind(&ok);
}
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698