Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: runtime/vm/intermediate_language_mips.cc

Issue 1184093004: Faster checks in polymorphic instance calls if Smi-s are involved (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_mips.cc
diff --git a/runtime/vm/intermediate_language_mips.cc b/runtime/vm/intermediate_language_mips.cc
index dc934ebe1e5b2f38a47fd1e10955e3ad99f869e4..a4546f9301494785fabc00ed9aaa8bc1bd234d06 100644
--- a/runtime/vm/intermediate_language_mips.cc
+++ b/runtime/vm/intermediate_language_mips.cc
@@ -4598,22 +4598,19 @@ void PolymorphicInstanceCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
return;
}
- // Load receiver into T0.
- __ LoadFromOffset(T0, SP, (instance_call()->ArgumentCount() - 1) * kWordSize);
Label* deopt = compiler->AddDeoptStub(
deopt_id(), ICData::kDeoptPolymorphicInstanceCallTestFail);
- LoadValueCid(compiler, T2, T0,
- (ic_data().GetReceiverClassIdAt(0) == kSmiCid) ? NULL : deopt);
-
+ Label ok;
compiler->EmitTestAndCall(ic_data(),
- T2, // Class id register.
instance_call()->ArgumentCount(),
instance_call()->argument_names(),
deopt,
+ &ok,
deopt_id(),
instance_call()->token_pos(),
locs());
+ __ Bind(&ok);
}

Powered by Google App Engine
This is Rietveld 408576698