Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1184093003: Revert of Fix clobbered register when setting this_function variable. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Fix clobbered register when setting this_function variable. (patchset #2 id:20001 of https://codereview.chromium.org/1185703002/) Reason for revert: [Sheriff] Makes mjsunit/es6/block-const-assign flaky, e.g.: http://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/4082 Original issue's description: > Fix clobbered register when setting this_function variable. > > R=arv@chromium.org > TEST=mjsunit/regress/regress-crbug-498022 > BUG=chromium:498022 > LOG=N > > Committed: https://crrev.com/bf2bbc8ba508ccd21edf3c08d2e4192c4764ae91 > Cr-Commit-Position: refs/heads/master@{#29020} TBR=arv@chromium.org,rossberg@chromium.org,mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:498022 Committed: https://crrev.com/06ac599d1ed7c3f309d74686eefdedfca6decf73 Cr-Commit-Position: refs/heads/master@{#29022}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -47 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-498022.js View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Fix clobbered register when setting this_function variable.
5 years, 6 months ago (2015-06-15 11:55:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184093003/1
5 years, 6 months ago (2015-06-15 11:55:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-15 11:56:15 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 11:56:34 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06ac599d1ed7c3f309d74686eefdedfca6decf73
Cr-Commit-Position: refs/heads/master@{#29022}

Powered by Google App Engine
This is Rietveld 408576698