Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1184093002: Removing unused functions from JSONValues class (Closed)

Created:
5 years, 6 months ago by shiva.jm
Modified:
5 years, 6 months ago
Reviewers:
Mike West
CC:
Habib Virji, pdr., Noel Gordon
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing unused functions from JSONValues class This patch removes the following unused functions: JSONValues::asValue() BUG=439559 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M Source/platform/JSONValues.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/JSONValues.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
shiva.jm
pls have a look.
5 years, 6 months ago (2015-06-15 11:02:41 UTC) #1
Mike West
On 2015/06/15 at 11:02:41, shiva.jm wrote: > pls have a look. Assuming everything compiles, LGTM.
5 years, 6 months ago (2015-06-15 11:26:29 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184093002/1
5 years, 6 months ago (2015-06-15 11:27:10 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-15 12:41:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184093002/1
5 years, 6 months ago (2015-06-16 03:15:48 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 03:19:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197155

Powered by Google App Engine
This is Rietveld 408576698