Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 1184083002: SkGIFMovie: Fix corrupted background color (Closed)

Created:
5 years, 6 months ago by Taka
Modified:
5 years, 6 months ago
Reviewers:
scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkGIFMovie: Fix corrupted background color The 'paintingColor' in onGetBitmap() was used to save the entire gif's background color while filling the 1st frame of a gif image, since it is 'static' qualified, so when re-entering this function for subsequent frames, this saved value will be used directly without re-obtaining it. But if asynchronous playing multi gif files in single process without being controlled, this 'static' will make the 'paintingColor' corrupted, because the different SkGIFMovie instances hold the same reference of 'paintingColor'. Signed-off-by: Lu Tong <lu.x.tong@sonymobile.com>; BUG=skia: Committed: https://skia.googlesource.com/skia/+/b5b50a07abb454abaf6ab46db20c6db6f5ecf9f6

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Change commit message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M src/images/SkMovie_gif.cpp View 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Taka
5 years, 6 months ago (2015-06-15 09:23:01 UTC) #2
mtklein
lgtm
5 years, 6 months ago (2015-06-15 09:47:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184083002/40001
5 years, 6 months ago (2015-06-15 09:47:44 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 09:52:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b5b50a07abb454abaf6ab46db20c6db6f5ecf9f6

Powered by Google App Engine
This is Rietveld 408576698