Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(68)

Issue 1184073004: Revert of Check if drawFocusRingMaskWithFrame:inView: exists when drawing focus ring (Closed)

Created:
4 years, 10 months ago by keishi
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Check if drawFocusRingMaskWithFrame:inView: exists when drawing focus ring (patchset #11 id:200001 of https://codereview.chromium.org/368003002/) Reason for revert: Tetsts failed on 10.7 because focus ring was not drawn. Original issue's description: > Check if drawFocusRingMaskWithFrame:inView: exists when drawing focus ring > > drawFocusRingMaskWithFrame:inView: only exists for Mac OS X 10.7 and later. > > BUG=328814, 425274 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196915 TBR=jiangj@opera.com,rsesek@chromium.org,tkent@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=328814, 425274 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197158

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -24 lines) Patch
M Source/core/layout/LayoutThemeMac.mm View 1 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/paint/ThemePainterMac.mm View 1 1 chunk +3 lines, -1 line 0 comments Download
M Source/platform/mac/ThemeMac.mm View 1 6 chunks +20 lines, -10 lines 0 comments Download
M Source/platform/mac/WebCoreNSCellExtras.h View 1 1 chunk +5 lines, -7 lines 0 comments Download
M Source/platform/mac/WebCoreNSCellExtras.mm View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
keishi
Created Revert of Check if drawFocusRingMaskWithFrame:inView: exists when drawing focus ring
4 years, 10 months ago (2015-06-15 20:51:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184073004/1
4 years, 10 months ago (2015-06-15 20:51:40 UTC) #2
commit-bot: I haz the power
Failed to apply patch for Source/core/layout/LayoutThemeMac.mm: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
4 years, 10 months ago (2015-06-15 20:52:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184073004/110001
4 years, 10 months ago (2015-06-16 06:45:52 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:110001) as https://src.chromium.org/viewvc/blink?view=rev&revision=197158
4 years, 10 months ago (2015-06-16 06:46:34 UTC) #8
tkent
4 years, 10 months ago (2015-06-16 06:51:09 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698