Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1766)

Unified Diff: Source/wtf/DequeTest.cpp

Issue 1184043002: Fix unit test style in Source/wtf/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: apply review comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/wtf/CheckedArithmeticTest.cpp ('k') | Source/wtf/FunctionalTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/wtf/DequeTest.cpp
diff --git a/Source/wtf/DequeTest.cpp b/Source/wtf/DequeTest.cpp
index 3a1b8c82c7eb4e657cb6fb0c2d6c8d03b393643c..3c66d31a42456c7d640d1432b54470f7b11cc493 100644
--- a/Source/wtf/DequeTest.cpp
+++ b/Source/wtf/DequeTest.cpp
@@ -24,7 +24,6 @@
*/
#include "config.h"
-
#include "wtf/Deque.h"
#include "wtf/HashSet.h"
@@ -32,6 +31,8 @@
#include "wtf/PassOwnPtr.h"
#include <gtest/gtest.h>
+namespace WTF {
+
namespace {
TEST(DequeTest, Basic)
@@ -163,7 +164,7 @@ private:
int* m_destructNumber;
};
-typedef WTF::Deque<OwnPtr<DestructCounter>> OwnPtrDeque;
+using OwnPtrDeque = Deque<OwnPtr<DestructCounter>>;
TEST(DequeTest, OwnPtr)
{
@@ -232,7 +233,8 @@ TEST(DequeTest, OwnPtr)
}
// WrappedInt class will fail if it was memmoved or memcpyed.
-static HashSet<void*> constructedWrappedInts;
+HashSet<void*> constructedWrappedInts;
+
class WrappedInt {
public:
WrappedInt(int i = 0)
@@ -313,4 +315,6 @@ TEST(DequeTest, SwapWithoutInlineCapacity)
dequeB.swap(dequeA);
}
-} // namespace
+} // anonymous namespace
+
+} // namespace WTF
« no previous file with comments | « Source/wtf/CheckedArithmeticTest.cpp ('k') | Source/wtf/FunctionalTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698