Fix unit test style in Source/wtf/.

Source/wtf/DequeTest.cpp

 /*
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
  * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
  * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
  * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
  * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
  * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
  * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
  * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
-
 #include "wtf/Deque.h"
 
 #include "wtf/HashSet.h"
 #include "wtf/OwnPtr.h"
 #include "wtf/PassOwnPtr.h"
 #include <gtest/gtest.h>
 
+namespace WTF {
+
 namespace {

[kochi, 2015/06/15 03:34:22]

Is this anonymous namespace necessary?

It seems anonymous namespace within namespace WTF is inconsistently
used in these tests in this CL.

Unless the name conflicts with symbols defined in other files,
technically it's fine to go without anonymous namespace,
but for consistency, do we enforce use of anonymous namespace
for file-local class/function/typedef etc. (i.e. anything without
test body)?

[tkent, 2015/06/15 03:49:23]

Yes, this CL keeps anonymous namespaces only if they are necessary.  I saw some
ODR violations without anonymous namespaces.
Any local helpers should be wrapped with anonymous namespace ideally.  However,
I don't intend to do it by myself at this moment.

[kochi, 2015/06/15 04:02:39]

Okay, then.

 
 TEST(DequeTest, Basic)
 {
     Deque<int> intDeque;
     EXPECT_TRUE(intDeque.isEmpty());
     EXPECT_EQ(0ul, intDeque.size());
 }
 
 void checkNumberSequence(Deque<int>& deque, int from, int to, bool increment)
 {
@@ skipping 179 matching lines @@
     deque.swap(copyDeque);
     EXPECT_EQ(0, destructNumber);
     EXPECT_EQ(count, copyDeque.size());
     EXPECT_EQ(0u, deque.size());
 
     copyDeque.clear();
     EXPECT_EQ(count, static_cast<size_t>(destructNumber));
 }
 
 // WrappedInt class will fail if it was memmoved or memcpyed.
 static HashSet<void*> constructedWrappedInts;

[kochi, 2015/06/15 03:34:22]

'static' keyword unnecessary in anonymous namespace.

[tkent, 2015/06/15 04:45:57]

Done.

 class WrappedInt {
 public:
     WrappedInt(int i = 0)
         : m_originalThisPtr(this)
         , m_i(i)
     {
         constructedWrappedInts.add(this);
     }
 
     WrappedInt(const WrappedInt& other)
@@ skipping 60 matching lines @@
     dequeA.swap(dequeB);
 
     ASSERT_EQ(1u, dequeA.size());
     EXPECT_EQ(1, dequeA.first().get());
     ASSERT_EQ(3u, dequeB.size());
     EXPECT_EQ(2, dequeB.first().get());
 
     dequeB.swap(dequeA);
 }
 
-} // namespace
+} // anonymous namespace
+
+} // namespace WTF