Issue 1183973010: Revert of chromoting: Add JS externs for qunit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1183973010: Revert of chromoting: Add JS externs for qunit. (Closed)

Created:
5 years, 6 months ago by James Hawkins

Modified:
5 years, 6 months ago

Reviewers:
garykac

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of chromoting: Add JS externs for qunit. (patchset #3 id:40001 of https://codereview.chromium.org/1196453003/) Reason for revert: Broke JSCompiler FYI bot Original issue's description: > chromoting: Add JS externs for qunit. > > This is one of a few fixes needed to enable ES6 mode in remoting/. > > BUG=481705 > > Committed: https://crrev.com/ffbf1b6110ff79b0f9683a4f4acc67baf4900499 > Cr-Commit-Position: refs/heads/master@{#335097} TBR=garykac@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=481705 Committed: https://crrev.com/28bf4a6f988e7e07c5533a15723c08d3a50efcfa Cr-Commit-Position: refs/heads/master@{#335113}

Created: 5 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -147 lines)			Patch
M	remoting/remoting_webapp_compile.gypi	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	remoting/remoting_webapp_files.gypi	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	remoting/webapp/build_template.gni	View	2 chunks	+1 line, -5 lines	0 comments	Download
D	remoting/webapp/externs/qunit.js	View	1 chunk	+0 lines, -129 lines	0 comments	Download
M	remoting/webapp/files.gni	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

James Hawkins

Created Revert of chromoting: Add JS externs for qunit.

5 years, 6 months ago (2015-06-18 20:33:40 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183973010/1

5 years, 6 months ago (2015-06-18 20:36:49 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-18 20:41:52 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/28bf4a6f988e7e07c5533a15723c08d3a50efcfa
Cr-Commit-Position: refs/heads/master@{#335113}