Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1183913006: Rename AppView to SkyBinding. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename AppView to SkyBinding. Move app/view.dart to rendering/sky_binding.dart since it's part of the RenderObject API, really (it knows about RenderView intimately). The tests pass. I didn't check every last example. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/406605b12a2bc4bdf5720b93acd2fa0f809c8f66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -214 lines) Patch
M sky/examples/game/main.dart View 3 chunks +7 lines, -8 lines 0 comments Download
M sky/examples/rendering/borders.dart View 2 chunks +4 lines, -7 lines 0 comments Download
M sky/examples/rendering/interactive_flex.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M sky/examples/rendering/justify_content.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M sky/examples/rendering/render_paragraph.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M sky/examples/rendering/sector_layout.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M sky/examples/rendering/shadowed_box.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M sky/examples/rendering/spinning_flex.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M sky/examples/rendering/touch_demo.dart View 3 chunks +2 lines, -4 lines 0 comments Download
M sky/examples/rendering/transform.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M sky/examples/stocks2/lib/stock_app.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/widgets/hello_widgets.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/widgets/sector.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/widgets/spinning_mixed.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/sdk/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
D sky/sdk/lib/app/view.dart View 1 chunk +0 lines, -136 lines 0 comments Download
A + sky/sdk/lib/rendering/sky_binding.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M sky/sdk/lib/widgets/widget.dart View 4 chunks +12 lines, -12 lines 0 comments Download
M sky/tests/examples/sector.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/tests/examples/stocks.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/tests/raw/box_layout.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/tests/raw/render_flex.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-17 23:57:22 UTC) #2
Hixie
5 years, 6 months ago (2015-06-18 00:07:34 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
406605b12a2bc4bdf5720b93acd2fa0f809c8f66 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698