chrome/browser/chromeos/login/auth/chrome_login_performer.h - Issue 1183893005: ChromeOS: user whitelist check should happen before entering password.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/auth/chrome_login_performer.h

Issue 1183893005: ChromeOS: user whitelist check should happen before entering password. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update after review. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/app_launch_signin_screen.cc ('k') | chrome/browser/chromeos/login/existing_user_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/auth/chrome_login_performer.h

diff --git a/chrome/browser/chromeos/login/auth/chrome_login_performer.h b/chrome/browser/chromeos/login/auth/chrome_login_performer.h

index 0920508c7fad8be440401c5302dcdccc8ece3301..800f6a13e9f76991f32cc00964f745a7c89e56a6 100644

--- a/chrome/browser/chromeos/login/auth/chrome_login_performer.h

+++ b/chrome/browser/chromeos/login/auth/chrome_login_performer.h

@@ -34,11 +34,12 @@ class ChromeLoginPerformer : public LoginPerformer {

explicit ChromeLoginPerformer(Delegate* delegate);

~ChromeLoginPerformer() override;

+ bool IsUserWhitelisted(const std::string& user_id,

+ bool* wildcard_match) override;

protected:

bool RunTrustedCheck(const base::Closure& callback) override;

void DidRunTrustedCheck(const base::Closure& callback);

- bool IsUserWhitelisted(const std::string& user_id,

- bool* wildcard_match) override;

void RunOnlineWhitelistCheck(const std::string& user_id,

bool wildcard_match,