Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1950)

Unified Diff: Source/platform/graphics/LoggingCanvas.cpp

Issue 1183863005: Paint Profiler: unroll SkPictures (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/graphics/LoggingCanvas.cpp
diff --git a/Source/platform/graphics/LoggingCanvas.cpp b/Source/platform/graphics/LoggingCanvas.cpp
index 2d0fb74c9698a12be834c6af7b2162e02dc60629..fb2801ac80315268f390b37306182154b5228e72 100644
--- a/Source/platform/graphics/LoggingCanvas.cpp
+++ b/Source/platform/graphics/LoggingCanvas.cpp
@@ -100,15 +100,6 @@ PassRefPtr<JSONArray> arrayForSkPoints(size_t count, const SkPoint points[])
return pointsArrayItem.release();
}
-PassRefPtr<JSONObject> objectForSkPicture(const SkPicture& picture)
-{
- const SkIRect bounds = picture.cullRect().roundOut();
- RefPtr<JSONObject> pictureItem = JSONObject::create();
- pictureItem->setNumber("width", bounds.width());
- pictureItem->setNumber("height", bounds.height());
- return pictureItem.release();
-}
-
PassRefPtr<JSONObject> objectForRadius(const SkRRect& rrect, SkRRect::Corner corner)
{
RefPtr<JSONObject> radiusItem = JSONObject::create();
@@ -785,9 +776,7 @@ void LoggingCanvas::onClipRegion(const SkRegion& region, SkRegion::Op op)
void LoggingCanvas::onDrawPicture(const SkPicture* picture, const SkMatrix* matrix, const SkPaint* paint)
{
- AutoLogger logger(this);
- logger.logItemWithParams("drawPicture")->setObject("picture", objectForSkPicture(*picture));
f(malita) 2015/06/17 18:20:56 It would be nice to provide some indication of pic
caseq 2015/06/17 18:29:47 Yup, I agree. We need to figure out how to present
- this->SkCanvas::onDrawPicture(picture, matrix, paint);
+ this->unrollDrawPicture(picture, matrix, paint, nullptr);
}
void LoggingCanvas::didSetMatrix(const SkMatrix& matrix)

Powered by Google App Engine
This is Rietveld 408576698