Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/android.py

Issue 1183863004: Force to disable slimming paint on Android when running layout tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/layout_tests/port/android.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/port/android.py b/Tools/Scripts/webkitpy/layout_tests/port/android.py
index 65feb52e02ddb845a9b6049d55eef09621464d5c..4888e0d1e6014849a9efae5a14b1360a85bbf92f 100644
--- a/Tools/Scripts/webkitpy/layout_tests/port/android.py
+++ b/Tools/Scripts/webkitpy/layout_tests/port/android.py
@@ -1066,7 +1066,12 @@ class ChromiumAndroidDriver(driver.Driver):
return self._android_commands.adb_command() + ['shell']
def _android_driver_cmd_line(self, pixel_tests, per_test_args):
- return driver.Driver.cmd_line(self, pixel_tests, per_test_args)
+ # FIXME: We can't enable slimming paint before crbug.com/439457 is fixed.
+ cmd_line = driver.Driver.cmd_line(self, pixel_tests, per_test_args)
+ if '--enable-slimming-paint' in cmd_line:
+ _log.warning('Android port doesn\'t support slimming paint because of crbug.com/439457')
+ cmd_line.remove('--enable-slimming-paint')
+ return cmd_line
@staticmethod
def _loop_with_timeout(condition, timeout_secs):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698