Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1183863003: Remove enclosingLayoutRect calls per FIXME. These are hot in profiles. (Closed)

Created:
5 years, 6 months ago by jbroman
Modified:
5 years, 5 months ago
Reviewers:
dsinclair, szager1
CC:
blink-reviews, krit, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, blink-reviews-rendering, f(malita), jchaffraix+rendering, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org, szager1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove enclosingLayoutRect calls per FIXME. These are hot in profiles. They convert from LayoutRect to FloatRect and back again, which is far from free. BUG=321237 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198000

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge with master #

Patch Set 3 : remove some toFloat calls (and subsequent reverse conversions), per szager #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -21 lines) Patch
M Source/core/layout/line/InlineFlowBox.h View 1 2 3 chunks +5 lines, -9 lines 0 comments Download
M Source/core/layout/line/InlineFlowBox.cpp View 3 chunks +3 lines, -9 lines 0 comments Download
M Source/core/layout/svg/line/SVGRootInlineBox.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
jbroman
(R=dsinclair, assignee of the bug in question) This saves about 1.4% of record time today ...
5 years, 6 months ago (2015-06-16 04:12:55 UTC) #2
dsinclair
+szager who's has a lot more knowledge of the LayoutUnit conversion then I do.
5 years, 6 months ago (2015-06-16 19:56:55 UTC) #4
szager1
https://codereview.chromium.org/1183863003/diff/1/Source/core/layout/line/InlineFlowBox.h File Source/core/layout/line/InlineFlowBox.h (right): https://codereview.chromium.org/1183863003/diff/1/Source/core/layout/line/InlineFlowBox.h#newcode271 Source/core/layout/line/InlineFlowBox.h:271: return LayoutRect(m_topLeft.x(), lineTop.toFloat(), width(), (lineBottom - lineTop).toFloat()); Can you ...
5 years, 6 months ago (2015-06-16 20:29:00 UTC) #5
jbroman
https://codereview.chromium.org/1183863003/diff/1/Source/core/layout/line/InlineFlowBox.h File Source/core/layout/line/InlineFlowBox.h (right): https://codereview.chromium.org/1183863003/diff/1/Source/core/layout/line/InlineFlowBox.h#newcode271 Source/core/layout/line/InlineFlowBox.h:271: return LayoutRect(m_topLeft.x(), lineTop.toFloat(), width(), (lineBottom - lineTop).toFloat()); On 2015/06/16 ...
5 years, 6 months ago (2015-06-16 23:50:30 UTC) #6
szager1
lgtm
5 years, 6 months ago (2015-06-20 00:36:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183863003/40001
5 years, 5 months ago (2015-06-29 12:58:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/36584)
5 years, 5 months ago (2015-06-29 13:04:02 UTC) #11
jbroman
dsinclair: Mind rubber-stamping this? szager doesn't seem to have enough OWNERS power.
5 years, 5 months ago (2015-06-29 14:06:58 UTC) #12
dsinclair
lgtm
5 years, 5 months ago (2015-06-29 14:08:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183863003/40001
5 years, 5 months ago (2015-06-29 14:08:57 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 16:32:20 UTC) #16
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198000

Powered by Google App Engine
This is Rietveld 408576698