google_apis/gcm/engine/gcm_store_impl.h - Issue 1183843002: Do not create GCM store if it is not needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/gcm_store_impl.h

Issue 1183843002: Do not create GCM store if it is not needed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback + fix test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/engine/gcm_store_impl.h

diff --git a/google_apis/gcm/engine/gcm_store_impl.h b/google_apis/gcm/engine/gcm_store_impl.h

index 8feebff048d52a51adfd2b9f81cb3a8559eb01f1..af89cff4352f2e0c60c8d86e602e81295e8bfa9a 100644

--- a/google_apis/gcm/engine/gcm_store_impl.h

+++ b/google_apis/gcm/engine/gcm_store_impl.h

@@ -31,7 +31,7 @@ class GCM_EXPORT GCMStoreImpl : public GCMStore {

~GCMStoreImpl() override;

// Load the directory and pass the initial state back to caller.

- void Load(const LoadCallback& callback) override;

+ void Load(StoreOpenMode open_mode, const LoadCallback& callback) override;

// Closes the GCM store.

void Close() override;

« no previous file with comments | « google_apis/gcm/engine/gcm_store.cc ('k') | google_apis/gcm/engine/gcm_store_impl.cc » ('j') | no next file with comments »