Issue 118384: Turn on DevTools Profiler....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118384: Turn on DevTools Profiler.... (Closed)

Created:
11 years, 6 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
pfeldman

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Turn on DevTools Profiler. Works on Windows and Linux. On Mac V8's sampling doesn't work with Chromium due to an unknown reason. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17866

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/renderer/render_process.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
	M	webkit/glue/devtools/js/inspector_controller_impl.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pfeldman

LGTM http://codereview.chromium.org/118384/diff/1/3 File chrome/renderer/render_process.cc (right): http://codereview.chromium.org/118384/diff/1/3#newcode105 Line 105: L"--prof --prof-lazy --logfile=*"); nit: i'd suggest leading ...

11 years, 6 months ago (2009-06-08 15:38:08 UTC) #2

mnaganov (inactive)

11 years, 6 months ago (2009-06-08 16:43:17 UTC) #3

http://codereview.chromium.org/118384/diff/1/3
File chrome/renderer/render_process.cc (right):

http://codereview.chromium.org/118384/diff/1/3#newcode105
Line 105: L"--prof --prof-lazy --logfile=*");
On 2009/06/08 15:38:08, pfeldman wrote:
> nit: i'd suggest leading space here instead of trailing in the previous line

Sure!

Expand Messages | Collapse Messages