Issue 1183833004: iOS: Wire up all gesture types in input_event.mojom

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1183833004: iOS: Wire up all gesture types in input_event.mojom (Closed)

Created:
5 years, 6 months ago by Chinmay

Modified:
5 years, 6 months ago

Reviewers:
kulakowski, abarth-chromium

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

iOS: Wire up all gesture types in input_event.mojom R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3175b58c6204552b18dff777616f07afc8cdb679

Patch Set 2 : Avoid locations in the window coordinate space #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+131 lines, -4 lines)			Patch
	M	sky/shell/ios/sky_surface.mm	View	1	4 chunks	+131 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kulakowski

https://codereview.chromium.org/1183833004/diff/1/sky/shell/ios/sky_surface.mm File sky/shell/ios/sky_surface.mm (right): https://codereview.chromium.org/1183833004/diff/1/sky/shell/ios/sky_surface.mm#newcode57 sky/shell/ios/sky_surface.mm:57: return input.Pass(); Pretty sure you can just return.

5 years, 6 months ago (2015-06-16 19:58:08 UTC) #5

Chinmay

5 years, 6 months ago (2015-06-16 20:17:27 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
3175b58c6204552b18dff777616f07afc8cdb679 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1183833004: iOS: Wire up all gesture types in input_event.mojom (Closed)

Description

Patch Set 1 #

Patch Set 2 : Avoid locations in the window coordinate space #

Messages