Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 1183803005: Add error struct to support the setSinkId operation for WebMediaPlayer. (Closed)

Created:
4 years, 10 months ago by Guido Urdaneta
Modified:
4 years, 10 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add error struct to support the setSinkId operation for WebMediaPlayer. A value of this struct will be returned to WebMediaPlayer in a callback. This is intended to support the Audio Output Devices API (http://w3c.github.io/mediacapture-output/) https://www.chromestatus.com/feature/4621603249848320 BUG=438023 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197107

Patch Set 1 #

Patch Set 2 : Fix year #

Patch Set 3 : Rename ErrorTypeObsolete to ErrorTypeAbort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
A + public/platform/WebSetSinkIdError.h View 1 2 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Guido Urdaneta
Hi, please review.
4 years, 10 months ago (2015-06-13 17:58:47 UTC) #2
tommi (sloooow) - chröme
lgtm
4 years, 10 months ago (2015-06-14 07:58:05 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183803005/40001
4 years, 10 months ago (2015-06-14 07:58:09 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-14 09:06:42 UTC) #7
Mike West
public/ LGTM.
4 years, 10 months ago (2015-06-15 08:10:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183803005/40001
4 years, 10 months ago (2015-06-15 08:38:16 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-15 10:01:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197107

Powered by Google App Engine
This is Rietveld 408576698