Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1183743003: Updates to the license information of third party components. (Closed)

Created:
5 years, 6 months ago by Michael Hablich
Modified:
5 years, 6 months ago
Reviewers:
ulan, danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Updates to the license information of third party components. LOG=n Committed: https://crrev.com/e35ff8cd03f4382dc8e59c4801499a94bcbb6c5e Cr-Commit-Position: refs/heads/master@{#29051}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Adressed comments #

Patch Set 3 : Reworded naming regarding sub dirs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -6678 lines) Patch
M LICENSE View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
A + src/third_party/valgrind/LICENSE View 1 3 chunks +15 lines, -6 lines 0 comments Download
A src/third_party/vtune/LICENSE View 1 1 chunk +59 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/third_party/object-keys.js View 1 chunk +0 lines, -68 lines 0 comments Download
A test/mjsunit/third_party/object-keys/LICENSE View 1 1 chunk +30 lines, -0 lines 0 comments Download
A + test/mjsunit/third_party/object-keys/object-keys.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D test/mjsunit/third_party/regexp-pcre.js View 1 chunk +0 lines, -6603 lines 0 comments Download
A test/mjsunit/third_party/regexp-pcre/LICENSE View 1 1 chunk +68 lines, -0 lines 0 comments Download
A + test/mjsunit/third_party/regexp-pcre/regexp-pcre.js View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Michael Hablich
PTAL I have not deleted the information in /LICENSE as I am not sure if ...
5 years, 6 months ago (2015-06-16 10:41:29 UTC) #2
ulan
Thanks a lot for fixing this! I see that js files are deleted, but not ...
5 years, 6 months ago (2015-06-16 10:55:50 UTC) #3
Michael Hablich
https://codereview.chromium.org/1183743003/diff/1/LICENSE File LICENSE (right): https://codereview.chromium.org/1183743003/diff/1/LICENSE#newcode29 LICENSE:29: Further license information can be found in individual sub-directories. ...
5 years, 6 months ago (2015-06-16 11:09:02 UTC) #4
ulan
lgtm with two comments > NOTRY=true Please remove this from description, since we are changing ...
5 years, 6 months ago (2015-06-16 11:39:56 UTC) #5
Michael Hablich
On 2015/06/16 11:39:56, ulan wrote: > lgtm with two comments > > > NOTRY=true > ...
5 years, 6 months ago (2015-06-16 11:57:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183743003/40001
5 years, 6 months ago (2015-06-16 12:14:31 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-16 12:37:43 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 12:38:01 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e35ff8cd03f4382dc8e59c4801499a94bcbb6c5e
Cr-Commit-Position: refs/heads/master@{#29051}

Powered by Google App Engine
This is Rietveld 408576698