Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 1183733004: fixes #25, most analyzer errors were not computed (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly
Modified:
5 years, 6 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fixes #25, most analyzer errors were not computed It helps to call computeErrors ;) R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/69a15615e9bf8efb03f943a5159ddc65bc6e9def

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -40 lines) Patch
M lib/devc.dart View 3 chunks +15 lines, -4 lines 0 comments Download
M lib/src/info.dart View 2 chunks +7 lines, -6 lines 0 comments Download
M test/codegen/expect/temps.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/report_test.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tool/sdk_expected_errors.txt View 8 chunks +70 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
5 years, 6 months ago (2015-06-12 23:12:18 UTC) #2
vsm
lgtm
5 years, 6 months ago (2015-06-12 23:36:49 UTC) #3
Jennifer Messerly
5 years, 6 months ago (2015-06-15 15:56:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
69a15615e9bf8efb03f943a5159ddc65bc6e9def (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698