Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 1183703002: Wrap devtoolslib doctests in a unittest so that the test runner sees them. (Closed)

Created:
5 years, 6 months ago by ppi
Modified:
5 years, 6 months ago
Reviewers:
viettrungluu, etiennej
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Wrap devtoolslib doctests in a unittest so that the test runner sees them.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
A mojo/devtools/common/devtoolslib/doctests_unittest.py View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ppi
Hi Trung or Etienne, ptal.
5 years, 6 months ago (2015-06-12 17:02:56 UTC) #2
viettrungluu
On 2015/06/12 17:02:56, ppi wrote: > Hi Trung or Etienne, > > ptal. What are ...
5 years, 6 months ago (2015-06-12 17:09:53 UTC) #3
ppi
For https://github.com/domokit/mojo/blob/master/mojo/devtools/common/devtoolslib/shell_arguments.py#L99 , because it seems a good fit for simple functions without side-effects. Is ...
5 years, 6 months ago (2015-06-12 17:16:04 UTC) #4
viettrungluu
On 2015/06/12 17:16:04, ppi wrote: > For > https://github.com/domokit/mojo/blob/master/mojo/devtools/common/devtoolslib/shell_arguments.py#L99 > , because it seems a ...
5 years, 6 months ago (2015-06-12 17:24:48 UTC) #5
ppi
5 years, 6 months ago (2015-06-12 17:28:33 UTC) #6
Or rather another way of writing tests - as this very CL adds a wrapper that
makes them runnable by the unittest framework.

Fair enough, I'll convert these to a unittest, thanks.

Powered by Google App Engine
This is Rietveld 408576698