Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1183633005: Dampen the old generation allocation limit only after the initial old generation size was configure… (Closed)

Created:
5 years, 6 months ago by ulan
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Dampen the old generation allocation limit only after the initial old generation size was configured. Otherwise, dampening interferes with initial size configuration and causes GC too early. BUG=501703 LOG=NO Committed: https://crrev.com/42263aab992b52d8eb5bfdc99fcbcadb4915aa36 Cr-Commit-Position: refs/heads/master@{#29106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/heap/heap.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL
5 years, 6 months ago (2015-06-18 09:05:06 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-18 09:12:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183633005/1
5 years, 6 months ago (2015-06-18 09:33:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 10:00:18 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 10:00:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42263aab992b52d8eb5bfdc99fcbcadb4915aa36
Cr-Commit-Position: refs/heads/master@{#29106}

Powered by Google App Engine
This is Rietveld 408576698