chrome/test/base/js2gtest.gni - Issue 1183633003: cross gn

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/js2gtest.gni

Issue 1183633003: cross gn Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: slightly smaller diff Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/base/js2gtest.gni

diff --git a/chrome/test/base/js2gtest.gni b/chrome/test/base/js2gtest.gni

index c4fde1f4865dd02e3155c6c28264130c70037b88..e265f124093925715abec559436cf630b7127925 100644

--- a/chrome/test/base/js2gtest.gni

+++ b/chrome/test/base/js2gtest.gni

@@ -39,7 +39,7 @@ template("js2gtest") {

v8_shell_path = get_label_info("//v8:v8_shell($snapshot_toolchain)",

"root_out_dir") + "/v8_shell"

- if (is_win) {

+ if (host_os == "win") {

v8_shell_path += ".exe"

}

« no previous file with comments | « chrome/installer/util/BUILD.gn ('k') | chrome_elf/BUILD.gn » ('j') | no next file with comments »